Skip to content

move VENDORED_GO_VERSION to top of file#594

Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:mainfrom
SgtCoDFish:move-vendored-go-version
Apr 17, 2026
Merged

move VENDORED_GO_VERSION to top of file#594
cert-manager-prow[bot] merged 1 commit intocert-manager:mainfrom
SgtCoDFish:move-vendored-go-version

Conversation

@SgtCoDFish
Copy link
Copy Markdown
Member

I open the tools module in my editor several times a week across different projects to answer the question "what Go version is this project using?"

This is a tiny quality-of-life fix which makes that question easier to answer, saving me from having to scroll / search and just putting the value at the top of the file.

If it's any help at all, here's what claude says about this very simple change:

No, there's no reason to expect problems from this change.

  The uncommitted change in modules/tools/00_mod.mk simply moves the VENDORED_GO_VERSION variable definition from line ~226 to line ~35 (near the top of the file, after the directory
   definitions).

  This is just a code reorganization - the variable still has the same value (1.26.2) and will work exactly the same way. Moving it earlier in the file is actually logical since it's
   a fundamental configuration variable that might be referenced later in the makefile.

  The change is purely cosmetic and safe.```

I open the tools module in my editor several times a week across
different projects to answer the question "what Go version is this
project using?"

This is a tiny quality-of-life fix which makes that question easier to
answer, saving me from having to scroll / search and just putting the
value at the top of the file.

Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2026
Copy link
Copy Markdown
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Cheers! 🚀

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2026
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2026
@cert-manager-prow cert-manager-prow bot merged commit 57d8090 into cert-manager:main Apr 17, 2026
5 checks passed
@SgtCoDFish SgtCoDFish deleted the move-vendored-go-version branch April 17, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants