ENT-13005: Added integrity check to cf-remote remote installation#174
ENT-13005: Added integrity check to cf-remote remote installation#174victormlg wants to merge 1 commit intocfengine:masterfrom
Conversation
victormlg
force-pushed
the
improved-remote-download
branch
from
6c48260 to
f43babf
Compare
victormlg
force-pushed
the
improved-remote-download
branch
from
f43babf to
c52900a
Compare
larsewi
left a comment
larsewi
left a comment
There was a problem hiding this comment.
Remember to test the script 😉
cf_remote/remote-download.sh
Outdated
|
|
||
| if [ -z "$HAS_SHA256SUM" ]; then | ||
| if [ "$INSECURE" -eq 0 ]; then | ||
| echo "Cannot check file integrity. sha256sum is not installed on host. Run with --insecure to skip" |
There was a problem hiding this comment.
The flag is -I but it says to use --insecure
| echo "Cannot check file integrity. sha256sum is not installed on host. Run with --insecure to skip" | |
| echo "Cannot check file integrity. sha256sum is not installed on host. Run with -I to skip" |
There was a problem hiding this comment.
The output of the script is printed by cf-remote. On cf-remote, the flag is --insecure, that's why I kept it like that
victormlg
force-pushed
the
improved-remote-download
branch
from
c52900a to
b680be0
Compare
larsewi
left a comment
larsewi
left a comment
There was a problem hiding this comment.
Most of these checks can be done before you actually download the file. Maybe do these checks first, and then download.
Ticket: ENT-13005 Signed-off-by: Victor Moene <[email protected]>
victormlg
force-pushed
the
improved-remote-download
branch
from
b680be0 to
8cb770f
Compare
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Please expand nt-discovery.sh and then do the error checking as early as possible (as fast as possible). This way you can detect errors right after running nt-discovery.sh, without having to transfer over another script.
| "wget", | ||
| "sha256sum", | ||
| ]: | ||
| path = discovery.get("NTD_{}".format(bin.upper())) |
There was a problem hiding this comment.
@victormlg AFAICT nt-discovery.sh won't check for these so, you won't have any data about then in the discovery dict. Need to expand nt-discovery.sh to look for wget and sha256sum
3 participants
No description provided.