replace snowflaked to avoid conflicts#117
Draft
gallone2000 wants to merge 1 commit into
Draft
Conversation
1e0c92a to
7ab6003
Compare
7ab6003 to
a6bc90b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
snowflakedcrate with custom implementationOverview
This PR removes the external
snowflakeddependency and replaces it with a custom, lock-free snowflake ID generator implementation. The new implementation maintains full behavioral compatibility withsnowflaked 1.0.3while providing equivalent or improved performance characteristics.Key Changes
snowflakedfrom production to dev-dependencies (used only for testing/oracle validation)Test Coverage
I implemented comprehensive test suites to ensure robustness and guard against future regressions:
Deterministic Tests
Oracle-Based Tests
snowflaked::Snowflake::from_partsProperty-Based Tests
proptestto explore large input spaces automaticallyIncludes CI-friendly seed control via
PROPTEST_SEEDenv var for deterministic property test execution.Performance
Benchmark suite included for regression detection.
Rationale
The custom implementation: