Repository navigation
Conversation
MoralCode
added
the
waiting
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
github-project-automation
Bot
moved this to Todo
in CollectOSS + 8Knot WG Feature Roadmap
MoralCode
moved this from Todo
to Paused/Background
in CollectOSS + 8Knot WG Feature Roadmap
MoralCode
added
the
needs-testing
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…are found Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…er side We are assuming we are working with a plain email Signed-off-by: Adrian Edwards <adredwar@redhat.com>
This helps handle the edge case where there are other words besides an email, separated by a space, in the string. Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…ext either side of the @ Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
MoralCode
force-pushed
the
feat/resolution_shortcut_ghnoreply
branch
from
October 8, 2026 01:27
5713b7a to
efb6b1f
Compare
MoralCode
removed
the
needs-testing
MoralCode
marked this pull request as draft
October 8, 2026 01:28
Contributor
Author
|
so far this is just email parsing utils. needs to implement the actual feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR shows what an implementation might look like if we wanted to account for github noreply user emails in the contributor resolution process since this specific email format makes it easier to connect a user to their commits with fewer API calls.
It also includes unit tested helpers for extracting and validating email addresses.
This PR fixes #256
Notes for Reviewers
Not yet tested
Signed commits