Skip to content

refactor: less nested remove_contact_from_chat#8108

Open
WofWca wants to merge 1 commit intomainfrom
wofwca/92d7d1b5e6
Open

refactor: less nested remove_contact_from_chat#8108
WofWca wants to merge 1 commit intomainfrom
wofwca/92d7d1b5e6

Conversation

@WofWca
Copy link
Copy Markdown
Collaborator

@WofWca WofWca commented Apr 9, 2026 •
edited
Loading

Hide whitespace for easier review. This simply utilizes early returns (bail and ensure) instead of if-else.

@WofWca WofWca marked this pull request as draft April 9, 2026 12:52
@WofWca WofWca force-pushed the wofwca/92d7d1b5e6 branch from 70ae7f3 to df665d9 Compare April 9, 2026 12:58
@WofWca WofWca marked this pull request as ready for review April 9, 2026 12:58
iequidoo
iequidoo approved these changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@iequidoo iequidoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/test_iroh_webxdc.py::test_no_duplicate_messages hung for unknown reason

@WofWca
Copy link
Copy Markdown
Collaborator Author

WofWca commented Apr 9, 2026

I re-ran the test. Green now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iequidoo iequidoo iequidoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WofWca @iequidoo