fix(processings): avoid to update view during live change - #4350
Open
tpoisseau wants to merge 6 commits into
Open
fix(processings): avoid to update view during live change#4350tpoisseau wants to merge 6 commits into
tpoisseau wants to merge 6 commits into
Conversation
Experimental: true
Contributor
Author
|
I try to make the CI pass, but it seems github runners have issues to call the prediction service : |
to properly support expected behavior matrix
to properly support expected behavior matrix
Deploying nmrium with
|
| Latest commit: |
4d735e3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b287a454.nmrium.pages.dev |
| Branch Preview URL: | https://946-we-should-reset-the-view.nmrium.pages.dev |
triggerOperation dispatch a new spectrum then call prepareLiveChange. But prepareLiveChange depends on `getSpectrum` scoped to the current state. So if we don't enforce the spectrum to prepareLiveChange. It uses the previous version of the spectrum, without the operation trigered. The algorithm puts an undefined operation in the processings. So next call to applyLiveChange crash. Refs: zakodium/nmrium#947 (comment)
tpoisseau
marked this pull request as ready for review
September 4, 2026 10:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental: true