Negotiating ECE#54
Open
chenBright wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
The RDMA endpoint already declares the intent to do ECE (Enhanced Connection Establishment) negotiation (
BringUpQpis gated byFLAGS_rdma_ece), but the existing implementation never exchanges ECE capabilities between the two peers.What is changed and the side effects?
Changed:
This PR implements an end-to-end ECE negotiation in the v3 handshake.
RdmaHandshakeClientV3::SendLocalHello): query local ECE, store it in_outgoing_ece, advertise it in the v3 hello.BringUpQp): apply the client's ECE during INIT->RTR (ibv_set_ece). After QP reaches RTS,ibv_query_eceto obtain the reduced/negotiated ECE (the subset both peers support) and store it in_outgoing_ece.SendLocalHello→FillLocalRdmaHello): advertise the negotiated ECE in the reply hello.BringUpQp): apply the server's reduced ECE during INIT->RTR.Side effects:
Performance effects:
Breaking backward compatibility:
Check List: