security: disable git credential persistence in checkout actions#281
Merged
Conversation
Remediate zizmor security finding by setting persist-credentials: false on all actions/checkout usages. This prevents unnecessary storage of git credentials in the GitHub Actions runner environment, reducing the attack surface if the runner is compromised. Changes: - Set persist-credentials: false on all 6 checkout actions across 3 workflows - Applied to dockerimage.yml, linting.yml, and update-current-image.yml - Credentials are still available for the current job but not persisted after
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remediate zizmor security finding by setting
persist-credentials: falseon allactions/checkoutusages across workflow files.Security Motivation
By default,
actions/checkoutpersists git credentials in the runner's git config. This increases the attack surface if the runner is compromised—an attacker could use the stored credentials to push malicious commits or access private repositories. Since these workflows don't require git push operations, credential persistence is unnecessary.Changes
persist-credentials: falseon all 6 checkout actionsRelated
Fixes zizmor finding: 'does not set persist-credentials: false'