Skip to content

fix(deps): patch sharp to 0.35.5 - #1151

Open
tobyhede wants to merge 1 commit into
mainfrom
fix/cip-4888-sharp
Open

tobyhede wants to merge 1 commit into
mainfrom
fix/cip-4888-sharp

Conversation

@tobyhede

@tobyhede tobyhede commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Raises the existing sharp pnpm override in pnpm-workspace.yaml from 0.35.4 to 0.35.5 to fix GHSA-wq5f-xc86-pv6w / CVE-2026-96889 (Dependabot alert #246). The bundled librsvg has a memory-safety bug that may allow remote code execution. sharp is still reached only as an optional dependency of next (image optimization).

  • Override: 'sharp@<0.35.4': '0.35.4' -> 'sharp@<0.35.5': '0.35.5'. The selector ceiling moves with the pin, as in the earlier sharp bumps.
  • Lockfile: only sharp and its @img/* platform binaries change (@img/sharp-* 0.35.4 -> 0.35.5, @img/sharp-libvips-* 1.3.3 -> 1.3.4). No other packages change.
  • 0.35.5 was published 2026-09-27, outside the 7-day minimumReleaseAge window.

Verification

  • pnpm install --frozen-lockfile succeeds.
  • pnpm why sharp -r reports a single version, sharp@0.35.5 (via next@15.5.24).
  • No sharp < 0.35.5 or libvips 1.3.3 entries remain in pnpm-lock.yaml.
  • The native module loads (require('sharp').versions: sharp 0.35.5, vips 8.18.7, rsvg 2.63.2).
  • Integrity hashes for sharp and a sample of the @img/* binaries match the npm registry.

Note: the lockfile was regenerated with --config.minimum-release-age=0 for this run only. Without it, changing the override forces a full re-resolve, and the cooldown then downgrades two versions that are already on main (express-rate-limit 8.7.1 -> 8.7.0, acorn 8.19.0 -> 8.18.0). The repo's minimumReleaseAge setting is unchanged.

Summary by CodeRabbit

  • Chores
    • Updated internal configuration. No user-facing changes are included in this update.

Raise the existing sharp override to 0.35.5 for GHSA-wq5f-xc86-pv6w /
CVE-2026-96889 (Dependabot alert #246): a memory-safety bug in the bundled
librsvg, with possible remote code execution, fixed in sharp >=0.35.5. The
selector ceiling moves with the pin so 0.35.4 cannot resolve. sharp is still
reached only as an optional dependency of next.

The lockfile change is limited to sharp and its @img/* platform binaries
(@img/sharp-* 0.35.5, @img/sharp-libvips-* 1.3.4). 0.35.5 was published
2026-09-27, outside the 7-day minimumReleaseAge window.
@changeset-bot

changeset-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7c653ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tobyhede
tobyhede requested a review from a team as a code owner October 12, 2026 01:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T01:08:13.178374Z 7c653ec PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 07772b0a-6da8-4545-b621-00b190571d3f

📥 Commits

Reviewing files that changed from the base of the PR and between 1e9fba3 and 7c653ec.


⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (1)
  • pnpm-workspace.yaml

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.



📝 Walkthrough

Walkthrough

The pnpm workspace sharp override now matches versions below 0.35.5 and pins them to 0.35.5.

Changes

Sharp Override

Layer / File(s) Summary
Update sharp override
pnpm-workspace.yaml
The override selector changes from below 0.35.4 to below 0.35.5. The pin changes from 0.35.4 to 0.35.5.

Priority: ⬆️ High

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: auxesis


Merge Risk: ⚪ Minimal · up to 7c653

The override and lockfile select sharp 0.35.5 and its corresponding binaries. No merge-blocking risk is established.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the dependency fix and the target sharp version, which matches the main change.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant