Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 472cbf0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The workspace resolves the MCP SDK to a version above the stated security floor, and the added check guards against vulnerable resolutions. No material merge risk is identified. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: updating @modelcontextprotocol/sdk to the patched 1.32.0 release. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
1 participant
Summary
Patches
@modelcontextprotocol/sdkfrom 1.29.0 to 1.32.0, which fixes Dependabot alert #247 (GHSA-6qxp-vccf-f47h / CVE-2026-104850). That advisory covers OAuth client credentials leaking to an authorization server chosen by a malicious MCP server. Affected range is >= 1.12.0 < 1.31.0.Why a direct dependency rather than an override
@modelcontextprotocol/sdkis not a direct dependency anywhere in the repo. Its only source is the auto-installed peer of@anthropic-ai/claude-agent-sdk(^1.29.0). The latest claude-agent-sdk (0.3.296) still declares^1.29.0, so bumping the parent doesn't help. pnpm overrides rewrite peer ranges, not peer resolutions. So this uses the same approach as the existing@anthropic-ai/sdkpin (alert #128): add an explicit^1.32.0dependency to@cipherstash/wizard, which forces the peer to resolve to the patched version.languages/typescript/packages/wizard/package.json: adds"@modelcontextprotocol/sdk": "^1.32.0". This is a peer-resolution pin only, because wizard never imports it.pnpm-lock.yaml: changes only the MCP SDK version.pnpm-workspace.yaml: adds a comment next to the existing peer-pin note..changeset/wizard-mcp-sdk-security-pin.md: patch changeset, because wizard's published manifest changes.e2e/tests/supply-chain.e2e.test.ts: asserts that every resolved@modelcontextprotocol/sdkis >= 1.31.0, mirroring the@anthropic-ai/sdkassertion.1.32.0 was published 2026-10-02, so it is past the 7-day
minimumReleaseAge. 1.32.1 is not yet. The lockfile was re-resolved under the repo config. Two unrelated cooldown demotions from that re-resolve were reverted by hand (express-rate-limit 8.7.1→8.7.0 and acorn 8.19.0→8.18.0). As a result the lockfile diff touches only@modelcontextprotocol/sdk, andpnpm install --frozen-lockfilepasses.Is a code change needed for OAuth usage?
No. The advisory says that for some usages upgrading is not enough: bundled providers need
expectedIssuer, and stored credentials may lackissuer. Those cases only apply to code that uses the SDK's OAuth client. I searched the repo for@modelcontextprotocol,authProvider,withOAuth,fetchToken,ClientCredentialsProvider,PrivateKeyJwtProvider,OAuthClientProvider,expectedIssuer,createSdkMcpServerandmcpServers, and found no matches outside node_modules. Nothing in this repo uses the MCP SDK's OAuth client, and wizard does not configure MCP servers. The dependency bump alone is sufficient.Verification
pnpm install --frozen-lockfile: passese2e/tests/supply-chain.e2e.test.ts: 29/29 pass, including the new assertion@cipherstash/wizard:typecheckandbuildpass.testhas 325 passed. Two suites (interface.test.ts) fail to load locally because the@cipherstash/authnative binding isn't built in a fresh worktree. That is an environment issue unrelated to this change, and CI builds the binding.@modelcontextprotocol/sdk< 1.31.0 remains inpnpm-lock.yaml.e2e/wasm/deno.lockdoes not reference it.Summary by CodeRabbit