Add PostgreSQL 19 image and pkgvars entry - #383
Open
ibrahim halatci (ihalatci) wants to merge 1 commit into
Open
Add PostgreSQL 19 image and pkgvars entry#383ibrahim halatci (ihalatci) wants to merge 1 commit into
ibrahim halatci (ihalatci) wants to merge 1 commit into
Conversation
Additive-only groundwork for PostgreSQL 19 support: - pkgvars: add postgres_19_version=19beta3. This is the entry that citusdata/tools' test_pkgvar_postgres_version_existence asserts against this repository, so it unblocks citusdata/tools#423. - Add postgres-18/Dockerfile and postgres-19/Dockerfile. - postgres-17/Dockerfile: bump hll to 2.21.citus-1 and topn to 2.7.1.citus-1, both now published for PostgreSQL 14-19. Nothing here changes what gets published. The new directories are inert because the publish workflow matrices do not reference postgres_18 or postgres_19 yet, and postgres_16 keeps both its matrix entry and its pkgvars line. The publish matrices, the tools pin bump, removal of postgres-16 and retargeting latest/alpine onto PostgreSQL 19 are deliberately held back: the first three depend on a new tools tag, and the last must wait for the PostgreSQL 19 GA release so that the latest tag is never built on a beta. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ed7b58a-0ba9-4f47-a1de-3ee665bae7f2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additive-only groundwork for PostgreSQL 19. Nothing here changes what gets published.
Changes
pkgvarspostgres_19_version=19beta3postgres-17/Dockerfile2.19→2.21.citus-1, topn2.7.0→2.7.1.citus-1postgres-18/Dockerfilepostgres-19/Dockerfile4 files, +87/-2.
Why this is safe to merge now
The publish workflow matrices are unchanged — they remain
[latest, alpine, postgres_17, postgres_16, nightly]. Nothing referencespostgres_18orpostgres_19, so the two new directories are inert; they are only built once a follow-up PR adds them to the matrices.postgres_16keeps both its matrix entry and itspkgvarsline, so the existingpostgres_16job is unaffected.latestandalpinestill buildFROM postgres:18.4. Retargeting them onto PostgreSQL 19 is deliberately not in this PR — doing it now would point thelatestDocker Hub tag at a beta PostgreSQL.The only image this PR changes that the matrices actually build is
postgres_17. Both new extension versions are published for PG17 on all supported distros (verified againstrepos.citusdata.com:postgresql-17-hll 2.21.citus-1,postgresql-17-topn 2.7.1.citus-1), so that build is expected to stay green.Why this PR exists separately
citusdata/tools'stest_pkgvar_postgres_version_existenceclones this repository and assertspkgvarscontainspostgres_19_version. That makes this the gating change for citusdata/tools#423, which is currently 41 green / 1 red on exactly that assertion. The same ordering was used for PostgreSQL 18: docker5fac2a8landed before the matching tools change.Held back for follow-ups
Deferred until a new tools tag exists (the current
-b v0.8.36pin has nopostgres_19inDockerImageType):postgres_18/postgres_19to the three publish matricespostgres-16/and droppostgres_16_versionDeferred until PostgreSQL 19 GA:
Dockerfileandalpine/DockerfileFROM→ PostgreSQL 19README.mdPostgreSQL version referenceNote on CI
publish_docker_images_on_push.ymland_cron.ymltrigger onpush: branches: "**", so they run on this branch. They build only —publish_docker.pycomputeswill_image_be_publishedfromget_current_branch() != "master", so no image is pushed to Docker Hub from a feature branch.