Skip to content

Phase 6A: drop retained PAT shadows (all-pg-azure-storage) - #1200

Merged
ibrahim halatci (ihalatci) merged 1 commit into
all-pg-azure-storagefrom
migrate/all-pg-azure-storage-drop-pat-shadow
Aug 6, 2026
Merged

ibrahim halatci (ihalatci) merged 1 commit into
all-pg-azure-storagefrom
migrate/all-pg-azure-storage-drop-pat-shadow

Conversation

@ihalatci

Copy link
Copy Markdown
Contributor

Phase 6A shadow removal for the all-pg-azure-storage build branch.

Removes the dead top-level env: PAT shadows pointing at secrets.GH_TOKEN (now a DEAD secret after the GitHub App token migration). These shadowed nothing useful: each job's Export app token to environment step already exports the real per-job token via echo "GH_TOKEN=..." / echo "GITHUB_TOKEN=..." >> $GITHUB_ENV minted by actions/create-github-app-token@v3.

Surgical change: 3 line deletions across 2 files, 0 insertions.

  • .github/workflows/build-package.yml: drop top-level GH_TOKEN and GITHUB_TOKEN env lines.
  • .github/workflows/build-pgazure-nightlies.yml: drop top-level GH_TOKEN env line.

Mirrors what was already merged on develop via #1195/#1196.

Draft — merge held.

…lows

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 21828aca-24f9-441b-8e36-981b7666b5c0
@ihalatci
ibrahim halatci (ihalatci) marked this pull request as ready for review August 6, 2026 13:22
@ihalatci
ibrahim halatci (ihalatci) merged commit 2f61240 into all-pg-azure-storage Aug 6, 2026
2 of 3 checks passed
@ihalatci
ibrahim halatci (ihalatci) deleted the migrate/all-pg-azure-storage-drop-pat-shadow branch August 6, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants