Fix memory leak when deleting base object without virtual destructor#219
Open
kf-chora wants to merge 1 commit intoclMathLibraries:masterfrom
Open
Fix memory leak when deleting base object without virtual destructor#219kf-chora wants to merge 1 commit intoclMathLibraries:masterfrom
kf-chora wants to merge 1 commit intoclMathLibraries:masterfrom
Conversation
Author
|
Hmm. I now realize that this is already fixed in the develop branch. Any plans on doing a release? The version included in the ubuntu package repository contains the bug fixed by above commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for
AddressSanitizerdiscoverednew-delete-type-mismatch. Deleting an object of a derived class through its base class without a virtual destructor results in undefined behavior.