CI improvements #127
Merged
CI improvements #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pks-gitlab
force-pushed
the
pks-ci-improvements
branch
7 times, most recently
from
f0f86fc to
4231366
Compare
Author
|
This detects the issue in #126. Will merge after that PR is merged. |
We're using an `int i` to index through an array. This causes a "-Wsign-compare" warning because the array size is unsigned, whereas the index is signed. Fix this by using a `size_t` index.
We don't currently enable "-Werror" in our GitHub CI jobs, which means that compiler warnings will not be detected at all. Enable this flag and more warnings so that we don't miss any issues that could have been detected by the compiler.
Some warnings may only be generated on 32 bit systems. Add a new job to compile on a 32 bit Linux system to more readily detect such issues. Note that we're not using Ubuntu here, but Debian. Ubuntu does not receive updates for its 32 bit Docker image anymore.
pks-gitlab
force-pushed
the
pks-ci-improvements
branch
from
4231366 to
adbe14f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a couple of CI improvements: