feat: Added error with docs URL in Core 3 for <SignedIn> and <SignedOut> - #9273
feat: Added error with docs URL in Core 3 for <SignedIn> and <SignedOut>#9273royanger wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 805673e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
API Changes Report
Summary
@clerk/nextjsCurrent version: 7.6.2 🟢 Additions (3)Added:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds runtime migration-error placeholders for the removed Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/nextjs/src/__tests__/removedControlComponents.test.ts (1)
3-17: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winCover the public package export.
These tests bypass
packages/nextjs/src/index.ts, so a broken@clerk/nextjsre-export could pass. Add a small API-surface test importingSignedInandSignedOutthrough the package entrypoint.As per coding guidelines, new functionality should include comprehensive coverage.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/nextjs/src/__tests__/removedControlComponents.test.ts` around lines 3 - 17, Extend the tests in “removed control components” to import SignedIn and SignedOut through the public package entrypoint exposed by packages/nextjs/src/index.ts, and add API-surface assertions that both exports retain the same docs-linked throwing behavior. Keep the existing direct-module tests intact while ensuring the package re-exports are exercised.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/nextjs/src/__tests__/removedControlComponents.test.ts`:
- Around line 3-17: Extend the tests in “removed control components” to import
SignedIn and SignedOut through the public package entrypoint exposed by
packages/nextjs/src/index.ts, and add API-surface assertions that both exports
retain the same docs-linked throwing behavior. Keep the existing direct-module
tests intact while ensuring the package re-exports are exercised.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 7157b661-6b9a-4959-b697-027193ce9ee7
📒 Files selected for processing (4)
.changeset/signed-in-signed-out-error.mdpackages/nextjs/src/__tests__/removedControlComponents.test.tspackages/nextjs/src/index.tspackages/nextjs/src/removedControlComponents.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
clerk/clerk_go(manual)clerk/dashboard(manual)clerk/accounts(manual)clerk/backoffice(manual)clerk/clerk(manual)clerk/clerk-docs(manual)clerk/cloudflare-workers(manual)clerk/cli(auto-detected)clerk/clerk-ios(auto-detected)clerk/clerk-android(auto-detected)
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change