Skip to content

fix(ui): align dialog close icon, not its button box, with the corner inset #9429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxyinger merged 2 commits into from
Aug 13, 2026
+11 −4
Merged

fix(ui): align dialog close icon, not its button box, with the corner inset #9429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ef5054
fix(ui): align dialog close icon, not its button box, with the corner…
maxyinger Aug 13, 2026
ff0798d
chore(repo): add changeset
maxyinger Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/dialog-close-icon-flush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
Comment on lines +1 to +2

@coderabbitai coderabbitai Bot Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Add a package-specific patch changeset.

This file contains no package entry or release description. Because the change updates runtime behavior in packages/ui, add a patch entry for the owning published package and describe the dialog close-icon fix.

As per coding guidelines, Changesets must manage versioning and changelogs. Based on learnings, an empty changeset is acceptable only when no published package requires a release entry; this change is a runtime UI fix.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.changeset/dialog-close-icon-flush.md around lines 1 - 2, Add a Changesets
patch entry for the published package owning packages/ui and include a concise
release description of the dialog close-icon fix; replace the empty frontmatter
in dialog-close-icon-flush.md with the required package-specific metadata.

Sources: Coding guidelines, Learnings

13 changes: 9 additions & 4 deletions packages/ui/src/mosaic/components/dialog/dialog.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,16 @@ export const styles = stylex.create({
},
});

/** Distance from the popup's corner, per surface. */
/**
* Positions the ICON the surface's inset from the corner, not the button box: the `sm` circle
* carries `(space[7] - space[4]) / 2` = `space[1.5]` of its own padding around the glyph, so each
* inset runs that much shy of the distance the eye should read (`4` for prompt/card, `4.5` for
* panel). The hit target hangs past the icon toward the corner, which only helps.
*/
export const closeInsets = stylex.create({
prompt: { insetBlockStart: space['4'], insetInlineEnd: space['4'] },
card: { insetBlockStart: space['4'], insetInlineEnd: space['4'] },
panel: { insetBlockStart: space['4.5'], insetInlineEnd: space['4.5'] },
prompt: { insetBlockStart: space['2.5'], insetInlineEnd: space['2.5'] },
card: { insetBlockStart: space['2.5'], insetInlineEnd: space['2.5'] },
panel: { insetBlockStart: space['3'], insetInlineEnd: space['3'] },
});

/**
Expand Down
Loading