Add websocket idle timeout metric#5358
Merged
Merged
Conversation
cloutiertyler
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds a Prometheus counter for websocket clients that are disconnected after the server considers them idle:
spacetime_worker_ws_clients_idle_timed_out_total{database_identity=...}The counter is incremented at the existing websocket idle-timeout disconnect path, next to the
Client ... timed outlog.API and ABI breaking changes
None.
Expected complexity level and risk
Testing
rustup run 1.93.0 rustfmt crates/client-api/src/routes/subscribe.rs crates/core/src/worker_metrics/mod.rsgit diff --checkLC_ALL=en_US.UTF-8 LC_CTYPE=en_US.UTF-8 LANG=en_US.UTF-8 RUSTC=/Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin/rustc rustup run 1.93.0 cargo check -p spacetimedb-client-api -p spacetimedb-core