Skip to content

AIENG-304 Determining elapsed time #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnanda-cloudbees merged 2 commits into from
Feb 18, 2026
Merged

AIENG-304 Determining elapsed time #1236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72ba487
AIENG-304-elapsed-timestamp
mnanda-cloudbees Feb 10, 2026
a321642
Wording changes
mnanda-cloudbees Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 36 additions & 3 deletions launchable/test_runners/pytest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
import os
import pathlib
import subprocess
from typing import Generator, List
from datetime import datetime, timezone
from typing import Generator, List, Optional

import click
from junitparser import Properties, TestCase # type: ignore
Expand All @@ -13,7 +14,6 @@

from . import launchable


# Please specify junit_family=legacy for pytest report format. if using pytest version 6 or higher.
# - pytest has changed its default test report format from xunit1 to xunit2 since version 6.
# - https://docs.pytest.org/en/latest/deprecations.html#junit-family-default-value-change-to-xunit2
Expand All @@ -36,6 +36,15 @@
# <testcase classname="tests.test_mod.TestClass" name="test__can_print_aaa" file="tests/test_mod.py"
# line="3" time="0.001" />
#


def _timestamp_to_iso(ts: Optional[float]) -> Optional[str]:
# convert to ISO-8601 formatted date
if ts is None:
return None
return datetime.fromtimestamp(ts, tz=timezone.utc).isoformat()
Copy link
Contributor

@Konboi Konboi Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Is the timezone always UTC? Not local time zone of the environment??

Copy link
Author

@mnanda-cloudbees mnanda-cloudbees Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question is can one test run in a runner in one time zone and another on runner in a different time zone ?
If yes then we will need a single source of truth to calculate durations and elapsed time
Also many other related files in repo have datetime.datetime.now(datetime.timezone.utc).isoformat().

But we can change here, if needed.

Copy link
Contributor

@Konboi Konboi Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, if any problem occurre, then let's consider it.
You can ignore my comment



@click.argument('source_roots', required=False, nargs=-1)
@launchable.subset
def subset(client, source_roots: List[str]):
Expand Down Expand Up @@ -326,15 +335,39 @@ def parse_func(
else:
props = None

# extract raw timestamps
start_timestamp = data.get("start")
stop_timestamp = data.get("stop")

# convert to ISO-8601
start_timestamp_iso_format = _timestamp_to_iso(start_timestamp)
end_timestamp_iso_format = _timestamp_to_iso(stop_timestamp)

print(
f"DEBUG pytest timing start={start_timestamp_iso_format}, stop={end_timestamp_iso_format}"
)

event_data = {}
if start_timestamp_iso_format:
event_data["start_timestamp"] = start_timestamp_iso_format
if end_timestamp_iso_format:
event_data["stop_timestamp"] = end_timestamp_iso_format

test_path = _parse_pytest_nodeid(nodeid)
for path in test_path:
if path.get("type") == "file":
path["name"] = pathlib.Path(path["name"]).as_posix()

data_payload = event_data if event_data else None

# end_timestamp_iso_format is being passed as timestamp as it reflects event finalization
# start + duration = stop
# sending both start and stop time in the event data field
yield CaseEvent.create(
test_path=test_path,
duration_secs=data.get("duration", 0),
status=status,
stdout=stdout,
stderr=stderr,
data=props)
timestamp=end_timestamp_iso_format,
data=data_payload)
Loading