Regenerate testdata and adapt tests for golang 1.24+#1434
Open
elukey wants to merge 5 commits intocloudflare:masterfrom
Open
Regenerate testdata and adapt tests for golang 1.24+#1434elukey wants to merge 5 commits intocloudflare:masterfrom
elukey wants to merge 5 commits intocloudflare:masterfrom
Conversation
Add scripts to generate all the certs material under the various testdata directories, together with comments about how they are related with each other. The idea is to be able to programmatically control and regenerate the data when needed (certs expired, shaXXX deprecation, ..). The current issue is that most of the certs are expired or signed with SHA1, that is not allowed anymore by golang 1.24+. issue: cloudflare#1413
Author
|
@mitch292 Hi! Do you think that the PR is viable to be reviewed for the cfssl repo? It should be a good addition, restoring tests would be of a good benefit for the whole community. Lemme know :) |
Contributor
|
Hi @elukey - Yes I agree, getting these tests back in order on 1.24 and later would be great! I am just hesitant to commit to being able to have time to review in the short term. I will flag for my team as well to see if someone can take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In golang 1.24+ sha1 signing is not allowed anymore, and a lot of certs in various testdata directories are SHA1 signed. There are also expired certs, that all together make the test suite fails in a lot of way.
I used various AI tools to do the following:
Given how old sha1 signing is, I would really vote to get rid of it as a special use case and focus on golang 1.24+ compatibility.
Fixes: #1413 1413