Repository navigation
Conversation
Attribute outlines used an unbounded Vec, allowing a short boolean-attribute tag to allocate tens of MiB despite the rewriter memory limit. Use LimitedVec and propagate growth failures through tokenizer actions. Roll back failed charges and release capacity when tokens are emitted or dropped. Attribute-heavy pages can now fail with MemoryLimitExceeded rather than bypass the configured limit. Add framing, bailout and charge-lifetime regressions; give token-conformance fixtures room for the newly counted metadata.
edevil
requested review from
a team,
Noah-Kennedy,
jasnell and
orium
as code owners
October 20, 2026 16:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Charge lexer attribute-outline capacity to the existing shared memory limit before growing the buffer. This metadata previously used an unaccounted
Vec, allowing attribute-heavy tags to bypass the configured limit.Reuse
LimitedVec, propagate the existing memory error through attribute-completion actions, and release failed growth charges and completed-token capacity.Behavior change: sufficiently attribute-heavy tags can now return
MemoryLimitExceededwhere they previously exceeded the configured budget unnoticed. No new public options or attribute stripping; graceful bailout retains its existing raw-output behavior._integration_test(including HTML5lib fixtures), doctests, strict all-targets Clippy, and formatting pass. The shared-budget fixture is also checked on wasm32.