feat: agentic coding for browser rendered projects#352
feat: agentic coding for browser rendered projects#352
Conversation
|
Claude finished @karishnu's task in 2m 17s —— View job Code Quality & Security Review (Critical Path)Recommendation: ✅ APPROVE PR SummaryAdds agentic coding support for browser-rendered projects with preflight questions workflow and optional git disabling. This enables the agent to ask clarifying questions before building and operate without git for simplified browser-rendered contexts. PR Description
Addressed Issues
Code QualityCritical: None High: None Medium:
Low:
SecurityCritical: None High: None Medium: None Low:
Architecture NotesPositive observations:
Changes summary:
TestingRecommended test scenarios:
Final RecommendationApprove - This is a well-structured feature addition that:
The only suggestion is to add length validation for |
| } as const; | ||
|
|
||
| const initArgs = { ...baseInitArgs, templateInfo: { templateDetails, selection } } | ||
| const initArgs = { ...baseInitArgs, templateInfo: { templateDetails, selection }, preflightQuestions: body.preflightQuestions, disableGit: body.disableGit } |
There was a problem hiding this comment.
Medium: Consider adding length validation for preflightQuestions similar to the query validation (line 72).
The query field has MAX_AGENT_QUERY_LENGTH (20,000 chars) validation, but preflightQuestions is passed directly without similar checks. This could allow oversized payloads that affect LLM context limits.
| const initArgs = { ...baseInitArgs, templateInfo: { templateDetails, selection }, preflightQuestions: body.preflightQuestions, disableGit: body.disableGit } | |
| const initArgs = { ...baseInitArgs, templateInfo: { templateDetails, selection }, preflightQuestions: body.preflightQuestions?.slice(0, MAX_AGENT_QUERY_LENGTH), disableGit: body.disableGit } |
Summary
Adds agentic coding support for browser-rendered projects with preflight questions and optional git disabling. This enables the agent to ask clarifying questions before building and operate without git for browser-rendered contexts.
Changes
preflightQuestionsanddisableGitoptions to VibeClient initializationPreflightStateto track questioning flowask-preflight-question.tstool for pre-build user clarificationPromptVariant(presentation, interactive, browser) and git-aware prompt sectionsCodeGenArgswith new optional parametersMotivation
Browser-rendered projects operate differently from sandbox-based projects (no server-side container, browser iframe preview). This PR:
Testing
disableGit: trueremoves git tool from available toolsBreaking Changes
None - all new parameters are optional with backward-compatible defaults.