fix: Make wsgi streaming response handlers async - #191
Open
hoodmane wants to merge 2 commits into
Open
Conversation
hoodmane
force-pushed
the
hoodmane/wsgi-streaming-stack-switching
branch
from
August 7, 2026 20:03
a6244ea to
b3d02b4
Compare
So it's possible to stack switch inside of them. Also handle contextvars
hoodmane
force-pushed
the
hoodmane/wsgi-streaming-stack-switching
branch
from
August 7, 2026 20:04
b3d02b4 to
53e2f5e
Compare
ryanking13
approved these changes
Aug 10, 2026
ryanking13
left a comment
ryanking13
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. I left one question.
| async def pull(controller: Any) -> None: | ||
| try: | ||
| chunk = next(chunks, _END) | ||
| chunk = ctx.run(next, chunks, _END) |
Contributor
There was a problem hiding this comment.
So if we don't set this the contextvars can be leaked between requests? Does this only apply to the streaming response?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it's possible to stack switch inside of them. Also, make sure that contextvars are preserved.
On top of #189.