Repository navigation
[vite-plugin] Prepare v1 asset-ignore and Flagship runtime fixes - #16543
petebacondarwin wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: e70461e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@petebacondarwin (original author) @dario-piotrowicz (human ant-core approver): please check this v1 backport coverage of #16521 and approve it if it looks good. For v1, v1 uses the installed Miniflare asset walker, so consume invalid-encoding validation through the intended runtime rather than copying unused retained helpers or public tests. #16539 already supplies the published .1 runtime and #16542 the retained remote-proxy flag. This remains a draft: Miniflare 5.20261023.2-beta, Wrangler 4.154.1 and deploy-helpers 0.24.2 are not on npm yet (pending #16529); the parent lockfile is preserved without fabricated metadata. Regenerate the lock and validate the actual plugin asset/Explorer integration after publication before merging. |
|
@akshitsinha (original author) @dario-piotrowicz (human ant-core approver): please check this v1 backport coverage of #16489 and approve it if it looks good. For v1, v1 exposes Local Explorer and legacy Flagship bindings, so the same intended runtime supplies Explorer management by app ID and flag evaluation metadata; no public source/generated files or CLI tests are restored. #16539 already supplies the published .1 runtime and #16542 the retained remote-proxy flag. This remains a draft: Miniflare 5.20261023.2-beta, Wrangler 4.154.1 and deploy-helpers 0.24.2 are not on npm yet (pending #16529); the parent lockfile is preserved without fabricated metadata. Regenerate the lock and validate the actual plugin asset/Explorer integration after publication before merging. |
Consolidate the existing final backport diff before rebasing onto the current v1 stack. #16543
c6208ae to
45d19f8
Compare
5b4d991 to
2a73b54
Compare
Consolidate the existing final backport diff before rebasing onto the current v1 stack. #16543
45d19f8 to
e70461e
Compare
Backports the relevant dependency-delivered behavior from #16521 to Vite plugin v1, stacked on #16542, the retained remote-binding error fix. The same required runtime also supplies the v1-relevant portion of #16489; no second dependency-only mapping PR is needed.
V1 starts Miniflare with asset directories and exposes Local Explorer. Its next runtime needs to reject invalid UTF-8/null-containing
.assetsignorefiles instead of silently losing patterns, and support the updated local Flagship Explorer routes and evaluation metadata. Consume these through intended Miniflare5.20261023.2-beta, matching Wrangler4.154.1(dependency/peer and registry fixtures), and deploy-helpers0.24.2, as recorded by pending release #16529. Keep all three direct Miniflare consumers aligned and preserve privateworkspace:*references.The retained
workers-sharedignore helper has no runtime caller in v1: asset walking runs inside installed Miniflare/deploy-helpers. Copying that helper or its tests would not enable the behavior. No public source, generated Explorer files, CLI tests, or upstream dependency tests are restored. One plugin patch changeset describes the runtime behavior.Publication blocker: all three intended versions return npm HTTP 404. #16529 is still unmerged. This draft deliberately records intended manifest versions while leaving the genuine parent lockfile untouched. Do not merge until publication; regenerate the lock with pnpm, perform frozen installation, then run build, types/checks, retained tests/fixtures and plugin asset/Explorer dev/preview validation. No integrity or lockfile metadata is fabricated.
The parent published graph has passing build/check/tests/fixtures and relevant dev/preview playground validation. These results do not validate the unpublished versions in this draft.
Note
This is a contribution from an AI agent: Codex, under the authorized v1 backport automation.