Repository navigation
Conversation
ZPascal
marked this pull request as draft
October 7, 2026 20:25
ZPascal
force-pushed
the
integration-test-adaptions
branch
3 times, most recently
from
October 8, 2026 05:46
3b9b621 to
483635d
Compare
ZPascal
force-pushed
the
integration-test-adaptions
branch
from
October 10, 2026 04:15
483635d to
a4ad3db
Compare
Make the integration tests pass against a CAPI deployed on KinD. Client: - Send the "resources" field with every bits upload (v3 packages) and also as query parameter for v2 uploads without matched resources, as CAPI otherwise rejects them (CF-AppBitsUploadInvalid / missing :resources). - Add the CA certificates of the LDAP and SAML identity provider configurations. Integration tests: - Reserve the TCP ports handed out by the NameFactory on the default-tcp router group at startup, so the TCP route tests don't depend on the test order or the deployment's default range. Skipped together with the TCP routing tests (SKIP_TCP_ROUTING_TESTS).
ZPascal
force-pushed
the
integration-test-adaptions
branch
from
October 10, 2026 07:17
57252f5 to
2321e47
Compare
ZPascal
marked this pull request as ready for review
October 10, 2026 09:04
ZPascal
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration tests fail against the current CAPI deployed on KinD (see #1381). This PR fixes what broke for
5.x.x.Client
resourcesfield. CAPI otherwise rejects them (CF-AppBitsUploadInvalid/missing :resources).resourcespart is always added, as JSON, and is[]when there are no matched resources.resources=[]as a query parameter. Cloud Controller accepts it there, but only an empty list fits into a URL, so a non-empty list stays a form field only.LdapConfigurationandSamlConfigurationgot acaCertificateslist for the CA certificates of the identity provider.Integration tests
NameFactoryhands out (1025 to the maximum) on thedefault-tcprouter group. The TCP route tests no longer depend on the test order or on the default port range of the deployment. SettingSKIP_TCP_ROUTING_TESTSskips this. If there is nodefault-tcpgroup, it only logs a warning.Testing
cloudfoundry-client,cloudfoundry-client-reactorandcloudfoundry-operationspass on JDK 11async, and extended the v3 upload test to check theresourcespart.Connected PR
#1381