Remove fog-aws and fog-core, complete fog removal - #5288
Merged
Conversation
kathap
force-pushed
the
remove-fog-aws
branch
5 times, most recently
from
July 14, 2026 15:21
731f1cd to
d4349f3
Compare
3 tasks
johha
self-requested a review
July 20, 2026 09:32
kathap
marked this pull request as draft
July 21, 2026 13:22
kathap
force-pushed
the
remove-fog-aws
branch
2 times, most recently
from
July 27, 2026 10:55
711500f to
2900756
Compare
kathap
marked this pull request as ready for review
July 27, 2026 12:25
storage-cli is now the sole blobstore backend. Delete the fog blobstore classes, remove the fog branch from ClientProvider, and drop fog_connection config keys and the transitive fog-json/fog-xml deps. Migrate tests off Fog.mock! to a real local blobstore.
72 tasks
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Jul 28, 2026
Changes in cloud_controller_ng:
- Remove fog-aws and fog-core gems and all fog blobstore code
PR: cloudfoundry/cloud_controller_ng#5288
Author: Katharina Przybill <30441792+kathap@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the last remaining fog gems (fog-aws, fog-core) and all fog blobstore code. All other fog gems (fog-azure-rm, fog-google, fog-aliyun) were previously removed. storage-cli is the default blobstore backend and has fully replaced fog. Removing fog-aws and fog-core also drops their transitive deps (fog-json, fog-xml), completing the fog removal and reducing Dependabot maintenance burden.
A short explanation of the proposed change
This change removes the last two fog gems (fog-aws, fog-core) and deletes all remaining fog-based blobstore code from the Cloud Controller. The fog client, blob, CDN, and provider classes under lib/cloud_controller/blobstore/fog/ are deleted, and the fog branch is removed from the blobstore ClientProvider so storage-cli is now the sole blobstore backend. All fog_connection / fog_aws_storage_options config keys are dropped from the config schemas and YAML fixtures, and the legacy fog-provider translation (AWS→s3, webdav→dav) is removed from StorageCliClient.
The test suite is migrated off fog accordingly: Fog.mock! and AWS credential fixtures are replaced with a real local blobstore, blob test-doubles that pointed at the deleted FogBlob now use LocalBlob, and two shared contexts ('a remote blobstore', 'a seeded empty-file resource') centralize the setup that fog's global mock used to provide implicitly. A few local-blobstore correctness fixes surfaced during the migration are included (LocalBlob#content_length returns an Integer, LocalClient#delete_all respects root_dir).
An explanation of the use cases your change solves
Changes:
fixtures (cloud_controller.yml, bosh-lite.yml, port_8181_config.yml)
Test infrastructure (fog → local blobstore):
(resource-pool SHA seed)
Links to any other associated PRs
Remove fog provider support capi-release#671
Remove fog google blobstore support #5261
Remove fog aliyun blobstore support #5154
Remove fog-local and fog-openstack blobstore support #5197
Remove fog azure support from ccng coding and Gemfile #5118
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests