Repository navigation
feat: Add additional-values-files input to setup-cf action - #514
Conversation
63f4dfe to
40cd568
Compare
40cd568 to
e364570
Compare
|
I believe it would be better and more fitting to the reusable action scenario to open up a possibility to simply provide a custom Helmfile values, as described in https://github.com/cloudfoundry/kind-deployment#using-the-setup-cf-github-action Any caller would be able to have a yaml file with: charts:
capi:
version: x.x.xand won't be limited only to capi, such flag feels oddly specific without possibility to override version of all the other deployments |
794ee00 to
68e16d8
Compare
Makes sense, a capi-only flag doesn't scale. I dropped capi-version and added additional-values-files, which delivers the information into the |
68e16d8 to
e616070
Compare
e616070 to
1ede049
Compare
The
cf-java-clientwants a validation build against the CAPI release that matches the CC API version it supports. The action can deploy only whatversions.yamlspecifies, or the latestdevelopversions whenuse-latest-versionsis set.This adds an optional
additional-values-filesinput: a comma-separated list of Helmfile values files that is passed tomake upasADDITIONAL_VALUES_FILESand merged last. Callers can override any value, not just CAPI, e.g.:Relative paths are resolved against the calling workflow's workspace. By default the input is empty, so nothing changes for existing users.
This replaces the earlier, CAPI-specific
capi-versioninput, following review feedback.