Skip to content

feat: Add additional-values-files input to setup-cf action - #514

Merged
pbusko merged 1 commit into
cloudfoundry:mainfrom
ZPascal:feat/setup-cf-capi-version
Oct 6, 2026
Merged

pbusko merged 1 commit into
cloudfoundry:mainfrom
ZPascal:feat/setup-cf-capi-version

Conversation

@ZPascal

@ZPascal ZPascal commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

The cf-java-client wants a validation build against the CAPI release that matches the CC API version it supports. The action can deploy only what versions.yaml specifies, or the latest develop versions when use-latest-versions is set.

This adds an optional additional-values-files input: a comma-separated list of Helmfile values files that is passed to make up as ADDITIONAL_VALUES_FILES and merged last. Callers can override any value, not just CAPI, e.g.:

charts:
  capi:
    version: 1.222.0

Relative paths are resolved against the calling workflow's workspace. By default the input is empty, so nothing changes for existing users.

This replaces the earlier, CAPI-specific capi-version input, following review feedback.

@ZPascal
ZPascal requested a review from a team as a code owner October 6, 2026 05:00
@ZPascal
ZPascal marked this pull request as draft October 6, 2026 05:05
@ZPascal
ZPascal force-pushed the feat/setup-cf-capi-version branch from 63f4dfe to 40cd568 Compare October 6, 2026 05:24
@ZPascal
ZPascal marked this pull request as ready for review October 6, 2026 05:26
@ZPascal
ZPascal force-pushed the feat/setup-cf-capi-version branch from 40cd568 to e364570 Compare October 6, 2026 05:31
@pbusko

pbusko commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

I believe it would be better and more fitting to the reusable action scenario to open up a possibility to simply provide a custom Helmfile values, as described in https://github.com/cloudfoundry/kind-deployment#using-the-setup-cf-github-action

Any caller would be able to have a yaml file with:

charts:
  capi:
    version: x.x.x

and won't be limited only to capi, such flag feels oddly specific without possibility to override version of all the other deployments

@ZPascal ZPascal changed the title feat: Add capi-version input to setup-cf action feat: Add additional-values-files input to setup-cf action Oct 6, 2026
@ZPascal
ZPascal force-pushed the feat/setup-cf-capi-version branch from 794ee00 to 68e16d8 Compare October 6, 2026 09:06
@ZPascal

ZPascal commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

I believe it would be better and more fitting to the reusable action scenario to open up a possibility to simply provide a custom Helmfile values, as described in https://github.com/cloudfoundry/kind-deployment#using-the-setup-cf-github-action

Any caller would be able to have a yaml file with:

charts:
  capi:
    version: x.x.x

and won't be limited only to capi, such flag feels oddly specific without possibility to override version of all the other deployments

Makes sense, a capi-only flag doesn't scale. I dropped capi-version and added additional-values-files, which delivers the information into the make up call.

Comment thread .github/actions/setup-cf/action.yaml Outdated
Comment thread .github/actions/setup-cf/action.yaml Outdated
Comment thread .github/actions/setup-cf/action.yaml Outdated
@ZPascal
ZPascal force-pushed the feat/setup-cf-capi-version branch from 68e16d8 to e616070 Compare October 6, 2026 12:36
@ZPascal
ZPascal force-pushed the feat/setup-cf-capi-version branch from e616070 to 1ede049 Compare October 6, 2026 12:37
@ZPascal
ZPascal requested a review from pbusko October 6, 2026 12:37
@pbusko
pbusko merged commit 8eff1a3 into cloudfoundry:main Oct 6, 2026
3 checks passed
@ZPascal
ZPascal deleted the feat/setup-cf-capi-version branch October 6, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants