Merged
Conversation
# Conflicts: # example/package-lock.json # example/yarn.lock # package-lock.json
- Resolved merge conflicts between master (Expo 53 upgrade) and video layer feature - Updated dependencies to support Expo 53 while preserving video layer functionality - Combined README documentation for video layer with expo-av deprecation notes - Preserved adapter pattern from master in AdvancedVideo.tsx - Kept demo app structure from feature branch with updated dependencies - Added support for @expo/vector-icons and expo-font as optional dependencies for video layer
- Remove resizeMode and onPlaybackStatusUpdate props from CLDVideoLayer - Update RefObject types to allow null values - Replace AVPlaybackStatusSuccess with generic any type for compatibility - Fixed all TypeScript compilation errors
# Conflicts: # example/package-lock.json # package-lock.json # package.json
kalifyaniv-cloudinary
left a comment
kalifyaniv-cloudinary
left a comment
There was a problem hiding this comment.
great job in general 💪
Comment on lines
+21
to
+33
| // Create analytics object with feature 'G' for CLDVideoLayer | ||
| const videoLayerAnalytics = { | ||
| ...SDKAnalyticsConstants, | ||
| feature: 'G', | ||
| }; | ||
|
|
||
| let videoUrl: string; | ||
| try { | ||
| videoUrl = cldVideo.toURL({ trackedAnalytics: videoLayerAnalytics }); | ||
| } catch (analyticsError) { | ||
| console.warn('CLDVideoLayer: Failed to generate URL with analytics, falling back:', analyticsError); | ||
| videoUrl = cldVideo.toURL(); | ||
| } |
There was a problem hiding this comment.
why do we create a player for share? im confused
Contributor
Author
There was a problem hiding this comment.
Not sure I understand the question
This part of the code is responsible for the analytics part, where we attach the analytics token
There was a problem hiding this comment.
@adimiz1
forget this.
It seems that i misunderstood the code. I thought we create a new CloudinaryVideo for share. I see now that its just a parameter to the util.
all good!
Co-authored-by: kalifyaniv-cloudinary <[email protected]>
Co-authored-by: kalifyaniv-cloudinary <[email protected]>
Co-authored-by: kalifyaniv-cloudinary <[email protected]>
Co-authored-by: kalifyaniv-cloudinary <[email protected]>
Co-authored-by: kalifyaniv-cloudinary <[email protected]>
kalifyaniv-cloudinary
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
Add video layer
What does this PR address?
Are tests included?
Reviewer, please note:
Checklist: