Conversation
Member
|
I can approve after seeing a green build on your test PR: cloudscape-design/components#1530 We also should try a few more packages, just in case. Let's do the same test PRs in test-utils and browser-test-tools |
Member
Author
|
@just-boris added links to other draft PRs with the tests, should be green! |
just-boris
approved these changes
Sep 11, 2023
taheramr
added a commit
that referenced
this pull request
Sep 11, 2023
timogasda
pushed a commit
that referenced
this pull request
Oct 16, 2023
just-boris
pushed a commit
that referenced
this pull request
Dec 12, 2023
just-boris
pushed a commit
that referenced
this pull request
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Upgrading to the latest LTS version of nodejs 18 since nodejs 16 is getting an end of life.
Ran a test draft PRs for other repos consuming this repo but with this branch instead:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.