fix: Replace unsafe in-operator checks with compile-time type guards#237
Open
fix: Replace unsafe in-operator checks with compile-time type guards#237
Conversation
pan-kot
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
TypeScript doesn't validate the
inoperator at compile time —'banana' in objcompiles without error. This is the same class of bug that caused the COE (property filter not creating filtering tokens), where a'prop' in objcheck silently passed with an incorrect property name.All 3 source-file usages in this repo discriminate the
PropertyFilterProps.Token | PropertyFilterProps.TokenGroupunion — the exact same type that caused the original bug.Solution
Replace all raw
'prop' in objchecks with type guard functions that usekeyofto validate property names at compile time. If someone typos a property name, TypeScript will now surface a compile error instead of silently allowing it.Changes
src/common/property-filter-type-guards.ts— sharedisTokenGroup()andisToken()type guardssrc/pages/table-saved-filters/filter-set-modals.tsx— useisTokenGroup()src/fake-server/distributions.ts— useisTokenGroup()andisToken()test/e2e/a11y.test.ts— localisAxeError()type guard4 checks replaced across 3 files. Zero behavioral changes.
Verification
References
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.