Repository navigation
docs(coverage): record the e2e-coverage-report.mjs region ceiling beside the harness floor - #1287
Merged
Merged
Conversation
…ide the harness floor Resolves #1253 by the same route #1211 took for #1210: document the unreachable fallbacks rather than delete them or add an ignore marker. tests/tools/e2e-coverage-report.mjs sits at 97.98% regions and every one of its 10 uncovered regions is a defensive fallback no test can reach. The in-file note already listed eight of them; this adds the two it predates (the second fallback on the resolvedSources chain, and the parts.length === 0 arm in splitRangeAtBoundaries from #1240), states the resulting ceiling, and says how the list and the floor move together. tests/coverage-gate-thresholds.test.mjs records that ceiling next to --check-harness-file-regions so the floor #1250 raised to 97 is never set above what the file can measure, and refreshes the measured numbers to the suite this commit ships. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1253.
Decision
Option (c) from #1253, matching the precedent PR #1211 set for #1210: provably unreachable defensive fallbacks in the harness are documented in place, not deleted and not hidden behind an ignore marker the reporter would have to learn.
Change
Claims two files, both comment-only:
tests/tools/e2e-coverage-report.mjs: the existing unreachable-residual note gains the two entries it predates (the second?? []fallback on theresolvedSourceschain, andparts.length === 0 ? [range] : partsinsplitRangeAtBoundaries, added by test(e2e): credit coverage for runs that span a source boundary #1240), states the resulting 97.98% ceiling, and says how the list and the per-file floor move together.tests/coverage-gate-thresholds.test.mjs: records that ceiling beside--check-harness-file-regionsso the floor test(coverage): ratchet the per-file harness region floor 93 -> 97 #1250 raised to 97 is never set above what the file can measure, and refreshes the measured numbers to the suite this commit ships (harness files 99.32%, 1471/1481 regions).Verification
npm run test:unit:coverage:checkon this branch: 2315 tests pass, exit 0.tests/tools/e2e-coverage-report.mjsreports 100.00% lines / 97.98% regions with exactly the 10 regions the note lists (one per entry; two on theresolvedSourcesline), andharness filesreports 1471/1481 regions, so the 10 are the whole harness residual.