crhumanize: add ParseIEC variants - #30
Merged
Merged
Conversation
- Add `ParseIEC`, `ParseBytesIEC`, and `ParseBytesPerSecIEC`, which interpret unit prefixes as IEC (1024-based) units whether or not they carry the `i` indicator (e.g. both `1 KB` and `1 KiB` are 1,024). These can parse anything produced by `Format` with IEC units, including when the `OmitI` flag strips the `i`. - Allow `Exact` and `OmitI` to be used together; the combination used to panic, but the result now roundtrips exactly through the `ParseIEC` variants. - Add a test for the correspondence between the `SI` and `IEC` tables, which `parseUnit` now relies on. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
RaduBerinde
force-pushed
the
crhumanize-parse-iec
branch
from
August 23, 2026 16:26
349ad0d to
ebb91ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseIEC,ParseBytesIEC, andParseBytesPerSecIEC, whichinterpret unit prefixes as IEC (1024-based) units whether or not they
carry the
iindicator (e.g. both1 KBand1 KiBare 1,024). Thesecan parse anything produced by
Formatwith IEC units, including whenthe
OmitIflag strips thei.ExactandOmitIto be used together; the combination used topanic, but the result now roundtrips exactly through the
ParseIECvariants.
SIandIECtables,which
parseUnitnow relies on.Co-Authored-By: roachdev-claude roachdev-claude-bot@cockroachlabs.com
This change is