Skip to content

chore: extract Netlify site name into env var - #23378

Open
ebembi-crdb wants to merge 2 commits into
mainfrom
stanley/netlify-env-var
Open

chore: extract Netlify site name into env var#23378
ebembi-crdb wants to merge 2 commits into
mainfrom
stanley/netlify-env-var

Conversation

@ebembi-crdb

Copy link
Copy Markdown
Contributor

Summary

  • Extracts the hardcoded cockroachdb-docs Netlify site name in the changed_files workflow into a NETLIFY_SITE_NAME environment variable
  • Defaults to the current value (cockroachdb-docs) so behavior is unchanged
  • Makes it easy to update the preview URL after reconnecting Netlify to the new cockroachlabs org

Part of Project Stanley (EDUENG-720, Ticket 1).

Test plan

  • Verify the changed_files workflow still generates correct Netlify preview URLs on a test PR
  • Confirm that setting NETLIFY_SITE_NAME as a repository variable overrides the default

🤖 Generated with Claude Code

Replaces the hardcoded `cockroachdb-docs` Netlify site name in the
changed_files workflow with a `NETLIFY_SITE_NAME` env var (defaulting
to the current value). This makes it easy to update the preview URL
after reconnecting Netlify to the new org.

Part of Project Stanley (EDUENG-720, Ticket 1).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ebembi-crdb
ebembi-crdb requested a review from a team as a code owner May 21, 2026 15:25
@netlify

netlify Bot commented May 21, 2026

Copy link
Copy Markdown

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 354b6ec
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/6a144d4d14681e000873baba

@netlify

netlify Bot commented May 21, 2026

Copy link
Copy Markdown

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 354b6ec
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/6a144d4b051d5600080444be

@github-actions

Copy link
Copy Markdown

Files changed:

  • .github/workflows/changed_files.yml

@netlify

netlify Bot commented May 21, 2026

Copy link
Copy Markdown

Deploy Preview for cockroachdb-docs canceled.

Name Link
🔨 Latest commit 354b6ec
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/6a144d4b624218000844a7ff

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ebembi-crdb
ebembi-crdb requested a review from mohini-crl May 25, 2026 14:27
Sonichigo pushed a commit to Sonichigo/docs-1 that referenced this pull request Jul 21, 2026
Consolidates PRs cockroachdb#23378, cockroachdb#23379, cockroachdb#23380, cockroachdb#23406 into a single branch.

- Update all cockroachdb/docs GitHub URLs to cockroachlabs/docs across
  configs, workflows, templates, vale rules, and content files
- Add NETLIFY_SITE_NAME env var for Netlify preview URLs (default:
  cockroachlabs-docs)
- Add DOCS_ORG env var for GitHub org in docs-prs-reviews.go (default:
  cockroachlabs)
- Make GENERATED_DIAGRAMS_REPO configurable via env var in
  validate_branch_existence.py
- Remove contribute UI (View Source, Edit Page, Report Issue) since
  repo is now private
- Remove GitHub issue links from feedback widgets
- Update raw.githubusercontent.com download URLs in prod-deployment
  includes, app tutorials, and demo files
- Update community-tooling pages to remove "open a PR" language
- Fix stale Netlify preview link in v26.1.0 release notes

Tickets: EDUENG-720, EDUENG-751, EDUENG-753, EDUENG-726, EDUENG-729,
EDUENG-756, DOC-17219

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant