goodhistogram: add PrometheusCollector for registry integration#2
Open
angles-n-daemons wants to merge 2 commits intomainfrom
Open
goodhistogram: add PrometheusCollector for registry integration#2angles-n-daemons wants to merge 2 commits intomainfrom
angles-n-daemons wants to merge 2 commits intomainfrom
Conversation
|
|
Add a thin PrometheusCollector wrapper that implements prometheus.Collector, allowing a goodhistogram to be registered directly with a Prometheus registry for scraping. Recording remains on the Histogram itself; the collector only participates in the export path, adding zero overhead to the hot path. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
Add HistogramVec, a label-partitioned collection of Histograms that implements prometheus.Collector. WithLabelValues returns a *Histogram for direct int64 recording on the hot path; the vec handles Prometheus registration and scrape-time export with label pairs. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
angles-n-daemons
force-pushed
the
bdillmann/prometheus-collector
branch
from
79f22bd to
83a0ed6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PrometheusCollectortype that implementsprometheus.Collector, allowing a*Histogramto be registered with a Prometheus registry viah.ToPrometheusCollector(desc).*Histogramdirectly — the collector only participates in the scrape path, adding zero overhead to the hot path.Test plan
go build ./...passesgo test ./...passes