Skip to content

build(deps): hold libphonenumber 9.0.37 until the Android port catches up - #1269

Merged
bmc08gt merged 1 commit into
code/cashfrom
claude/dependabot-ignore-libphonenumber
Aug 20, 2026
Merged

build(deps): hold libphonenumber 9.0.37 until the Android port catches up#1269
bmc08gt merged 1 commit into
code/cashfrom
claude/dependabot-ignore-libphonenumber

Conversation

@bmc08gt

@bmc08gt bmc08gt commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Dependabot re-proposed com.googlecode.libphonenumber:libphonenumber 9.0.36 → 9.0.37 in #1259. Merging it would have put the two libphonenumber artifacts back into version skew — the exact thing #1258 fixed — because the Android port io.michaelrocks:libphonenumber-android has no 9.0.37 (latest on Maven Central is 9.0.36).

#1259 is closed, but closing is not enough. Dependabot said so on the way out:

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

The libphonenumber group added in #1258 is still doing its job — it makes skew visible in one diff when both artifacts have updates. What it does not do is prevent a group PR containing only one artifact when only that one has an update. So 9.0.37 would come back on the next scheduled run.

This adds an explicit ignore for that single version. Scoped to 9.0.37 deliberately, not to all patches: 9.0.38+ should still be offered, and by then the port may have caught up.

Follow-up worth doing

This will recur on every upstream release, because the port structurally lags. The durable fix is to stop depending on both artifacts at all — and it is small:

  • io.michaelrocks:libphonenumber-android (the port) is used throughout apps/flipcash/shared/phone/.../PhoneUtils.kt and its tests.
  • com.googlecode.libphonenumber:libphonenumber (Google's) has exactly one consumer: apps/flipcash/shared/onramp/coinbase/.../PhoneRegion.kt, using only parse and getRegionCodeForNumber — both present in the port.

Porting that one file lets the Google artifact be dropped entirely, at which point this ignore rule, the group rule, and the pinning comment in gradle/libs.versions.toml all become unnecessary.

@bmc08gt
bmc08gt requested a review from jeffyanta as a code owner August 20, 2026 14:01
@github-actions github-actions Bot added the type: build Build system, Gradle, dependencies label Aug 20, 2026
@bmc08gt
bmc08gt merged commit 9f5c02e into code/cash Aug 20, 2026
3 checks passed
@bmc08gt
bmc08gt deleted the claude/dependabot-ignore-libphonenumber branch August 20, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: build Build system, Gradle, dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant