build(deps): hold libphonenumber 9.0.37 until the Android port catches up - #1269
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot re-proposed
com.googlecode.libphonenumber:libphonenumber9.0.36 → 9.0.37 in #1259. Merging it would have put the two libphonenumber artifacts back into version skew — the exact thing #1258 fixed — because the Android portio.michaelrocks:libphonenumber-androidhas no 9.0.37 (latest on Maven Central is 9.0.36).#1259 is closed, but closing is not enough. Dependabot said so on the way out:
The
libphonenumbergroup added in #1258 is still doing its job — it makes skew visible in one diff when both artifacts have updates. What it does not do is prevent a group PR containing only one artifact when only that one has an update. So 9.0.37 would come back on the next scheduled run.This adds an explicit ignore for that single version. Scoped to 9.0.37 deliberately, not to all patches: 9.0.38+ should still be offered, and by then the port may have caught up.
Follow-up worth doing
This will recur on every upstream release, because the port structurally lags. The durable fix is to stop depending on both artifacts at all — and it is small:
io.michaelrocks:libphonenumber-android(the port) is used throughoutapps/flipcash/shared/phone/.../PhoneUtils.ktand its tests.com.googlecode.libphonenumber:libphonenumber(Google's) has exactly one consumer:apps/flipcash/shared/onramp/coinbase/.../PhoneRegion.kt, using onlyparseandgetRegionCodeForNumber— both present in the port.Porting that one file lets the Google artifact be dropped entirely, at which point this ignore rule, the group rule, and the pinning comment in
gradle/libs.versions.tomlall become unnecessary.