feat(chats): add the empty state to the v2 Chats tab - #1282
Merged
Conversation
An empty Chats tab rendered as a blank screen under the title. Replace it with the designed prompt (Figma 9340:2746): the outlined bubble mark, "No Chats Yet", and a line pointing at the two ways a conversation starts. To tell "no chats" from "not loaded yet", `tipChats` becomes a `Loadable`, so the prompt only appears once the chat feed has actually emitted rather than flashing over a list that is about to arrive. The list also picks up `LocalTabBarPadding`, which it was missing: rows were scrolling under the hoisted v2 tab bar, and the inset is what centers the empty state in the space the bar leaves visible. It is a no-op for v1, where the local is empty. Scoped to v2 — v1's Tips sheet keeps its bare list under the Tip Card button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the Chats empty state from Figma.
An empty Chats tab previously rendered as a blank screen under the title. It now shows the designed prompt: the outlined bubble mark, "No Chats Yet", and a line pointing at the two ways a conversation starts.
Changes
ic_bubble_outline.xml— the 64dpIconBubble3mark, converted from the Figma SVG. White stroke tinted at the call site, matching howic_nav_chatis set up.TipFlowViewModel—tipChatsbecomesLoadable<List<ConversationReference>>. Previously it defaulted toemptyList(), which can't distinguish "no chats" from "the feed hasn't emitted yet", so the prompt would flash over a list that was about to arrive.TipsScreen— renders the empty state when the feed is loaded and empty, using the same shape as the wallet's empty state (textLarge/textMaintitle,textSmall/textSecondaryprompt,grid.x3spacing). Adds a@Previewfor it.The design's secondary text (white at 50%) is already
CodeTheme.colors.textSecondaryin the Flipcash2 design system, so no hardcoded colors were needed.Notes for review
LocalTabBarPadding, which it was missing. Rows were scrolling under the hoisted v2 tab bar (unlikeWalletScreenContentandMenuScreenContent, which both apply it), and the inset is also what centers the empty state in the space the bar leaves visible. No-op for v1, where the local is empty. Happy to split this out if you'd rather keep the PR to the empty state alone.