Repository navigation
Conversation
A masked link shows text other than its address, so the warning now quotes that text next to the host: “label” will open host. A bare link keeps today's subtitle. The title, buttons and Don't ask again checkbox are unchanged. ExternalLinkOpener.open and DialogItem.leavingFlipcash take an optional label. Nothing passes one yet; the rendering PR supplies it when it routes masked-link taps here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping a masked link (
[label](url)) shows the existing warning with a new subtitle:“<label>” will open <host>. Never share your Access Key with a website.A bare link keeps its current subtitle. The warning's redesign is tracked separately; this changes copy only.ExternalLinkOpener.open(_:label:)andDialogItem.leavingFlipcash(host:label:...)take an optionallabel, defaultnil.LeavingFlipcashDialogTestsfor the masked subtitle; the bare-link test is unchanged.