Repository navigation
chore(core): pin shared-core 0.14.0 and test the TextFormat facade - #1035
Merged
Merged
Conversation
0.14.0 carries SharedCoreKit's TextFormat parser. The three manifests move together, and the workspace Package.resolved follows. TextFormatVectorTests runs the synced text_format.json (122 vectors) through TextFormat.parse in FlipcashCoreVectors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
flipcash-shared-core-spmfrom 0.10 to 0.14.0 in FlipcashCore, FlipcashUI and CrossPlatformVectors, and refreshes the workspacePackage.resolved. 0.14.0 addsTextFormat.parse, the Swift facade over the shared chat-markup parser.Adds
TextFormatVectorTeststo FlipcashCoreVectors. It runs the syncedtext_format.json(122 vectors) through the facade and comparesdisplay, spans and display ranges. The parser has its own suite in shared-core, so this only checks the bridge.First of the chat text formatting PRs; rendering stacks on this one.