Repository navigation
fix(share): render the share extension in Avenir - #1044
Merged
Merged
Conversation
The Send to screen used system text styles (.headline, .subheadline, .footnote), so it rendered in San Francisco while the rest of the app uses Avenir. Each element now takes the token ShareToChatsSheet uses for the same element, and the extension registers Avenir Medium and Demi at launch. registerNotificationFonts becomes registerExtensionFonts, since both extensions now call it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The share extension's Send to screen used system text styles (
.headline,.subheadline,.footnote), so it rendered in San Francisco instead of the app's Avenir.ShareToChatsSheetuses for the same element:.appBarButtonfor the title,.appTextSmallfor section headers, 17pt Demi for chat names,.appTextMessagefor the search and message fields, 17pt Medium for Send.ShareViewControllerregisters Avenir Medium and Demi at launch. The styles above stay within those two faces, so Regular isn't loaded into the extension's memory budget.FontBook.registerNotificationFonts()is renamedregisterExtensionFonts(), since the notification and share extensions both call it now.