fix: handle invalid slug gracefully to prevent CLI crash - #744
Open
sentry[bot] wants to merge 1 commit into
Open
fix: handle invalid slug gracefully to prevent CLI crash#744sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue CLI-2N, where the Codecov CLI would crash with an unhandled
ValueError: The provided slug is invalidwhen theslugargument was either not provided by the user or could not be auto-detected from the environment.Root Cause:
The
encode_slugfunction incodecov_cli/helpers/encoder.pyraises aValueErrorfor invalid orNoneslugs. Previously, thisValueErrorwas not caught by the calling service functions (e.g.,create_commit_logic), leading to an unhandled exception and a CLI crash.Solution:
safe_encode_slugincodecov_cli/helpers/encoder.py. This function wrapsencode_slugin atry-exceptblock, logs a user-friendly error message, and returnsNoneif the slug is invalid.encode_slugacross various service modules (e.g.,commit,report,empty_upload,upload_completion,upload_sender,get_report_results) to usesafe_encode_slug.safe_encode_slug: if it returnsNone, aclick.UsageErroris raised. This ensures the CLI exits cleanly with a clear error message to the user, rather than crashing.Fixes CLI-2N