Repository navigation
Fix bulk upload: store temp files on S3 - #3675
Merged
Merged
Conversation
Local disk left the validated file on one web node; Import on another failed with "Uploaded file no longer available". Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BULK_UPLOAD_TEMP_DISKto Amazon S3 so validate and import share the same temp file across web nodes and workers.temp/bulk-events/and log when the file is missing at import time.local/publicdisks inconfig/filesystems.php.Fixes admin bulk upload failing after Import with "Uploaded file no longer available."
Test plan
BULK_UPLOAD_TEMP_DISK=s3, clear config cache, deploy/admin/bulk-upload: upload spreadsheet → preview → Import succeedstemp/bulk-events/on the AWS bucket and are removed after importBULK_UPLOAD_TEMP_DISK=localstill works on a single machineMade with Cursor