Skip to content

⚡️ Speed up method StringUtils.aspectjNameToPattern by 25% #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method StringUtils.aspectjNameToPattern by 25% #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions rewrite-core/src/main/java/org/openrewrite/internal/StringUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,14 +618,16 @@ public static String aspectjNameToPattern(String name) {
}

int length = name.length();
StringBuilder sb = new StringBuilder(length);
// Pre-size to reduce resizing for common expansions (e.g. '*' -> "[^.]*")
StringBuilder sb = new StringBuilder(Math.max(16, length * 2));
char prev = 0;
for (int i = 0; i < length; i++) {
boolean isLast = i == length - 1;
char c = name.charAt(i);
char next = isLast ? 0 : name.charAt(i + 1);
switch (c) {
case '.':
if (prev != '.' && (isLast || name.charAt(i + 1) != '.')) {
if (prev != '.' && (isLast || next != '.')) {
sb.append("[.$]");
} else if (prev == '.') {
sb.append("\\.(.+\\.)?");
Expand Down