feat: support BackedEnum values in database binds#10256
Open
memleakd wants to merge 1 commit into
Open
Conversation
- Allow database escaping to use BackedEnum backing values - Support BackedEnum values in query bindings and Query Builder binds - Add focused tests and user guide examples Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for PHP
BackedEnumvalues in database escaping, query bindings, and escaped Query Builder values.It was inspired by @maniaba's forum post and #10223.
For apps that use native PHP enums for domain values, this makes database code a bit nicer to write:
CodeIgniter will use the enum's backing value when escaping it, so string-backed enums are treated like strings and int-backed enums are treated like integers.
This avoids repeating
->valueat every query call site, while keeping raw SQL and escape-disabled values in the caller's control.The implementation is intentionally small: enum cases are unwrapped during database escaping, so regular query bindings and escaped Query Builder values use the same existing path.
Checklist: