refactor: fix minor type inaccuracies found via PHPStan bleeding edge - #10522
Merged
paulbalandan merged 1 commit intoSep 5, 2026
Merged
Conversation
Member
|
Just to be sure: you're not planning to eventually switch |
michalsn
approved these changes
Sep 4, 2026
paulbalandan
force-pushed
the
bleeding-edge-cheap-wins
branch
from
September 5, 2026 11:20
797bf69 to
e430f85
Compare
Member
Author
Yes, not planning to have bleeding edge enabled. Just fixing any errors from it. |
paulbalandan
force-pushed
the
bleeding-edge-cheap-wins
branch
from
September 5, 2026 12:03
e430f85 to
d6ad142
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm trying to enable bleeding edge here but the 188 errors are not flexible enough to be done in one pass. Landing the cheap wins first.
Checklist: