Skip to content

fix(github-upload-public-key): use ssh_signing_keys uri - #1072

Open
v-atsai wants to merge 1 commit into
coder:mainfrom
v-atsai:patch-1
Open

fix(github-upload-public-key): use ssh_signing_keys uri#1072
v-atsai wants to merge 1 commit into
coder:mainfrom
v-atsai:patch-1

Conversation

@v-atsai

@v-atsai v-atsai commented Aug 21, 2026

Copy link
Copy Markdown

Description

Type of Change

  • New module
  • New template
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/coder/modules/github-upload-public-key
New version: v1.1.1
Breaking change:

  • Yes
  • No

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun fmt)
  • Changes tested locally

Related Issues

@35C4n0r
35C4n0r self-requested a review August 25, 2026 17:14

@35C4n0r 35C4n0r left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-atsai adding a signing key should be an additional feature in the module, we don't want to replace the current behaviour of the module from adding authentication SSH key to signing SSH key.
I'd suggest to add a new optional variable where users can key_type auth(default)/signing/both, this would add signing as an additive option rather than a replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants