fix(github-upload-public-key): use ssh_signing_keys uri - #1072
Open
v-atsai wants to merge 1 commit into
Open
Conversation
35C4n0r
self-requested a review
August 25, 2026 17:14
35C4n0r
requested changes
Aug 26, 2026
35C4n0r
left a comment
Collaborator
There was a problem hiding this comment.
@v-atsai adding a signing key should be an additional feature in the module, we don't want to replace the current behaviour of the module from adding authentication SSH key to signing SSH key.
I'd suggest to add a new optional variable where users can key_type auth(default)/signing/both, this would add signing as an additive option rather than a replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Module Information
Path:
registry/coder/modules/github-upload-public-keyNew version:
v1.1.1Breaking change:
Testing & Validation
bun test)bun fmt)Related Issues