refactor: improve keyring support reliability and reduce duplication#831
Merged
refactor: improve keyring support reliability and reduce duplication#831
Conversation
Collaborator
EhabY
commented
Mar 9, 2026
EhabY
commented
- Separate keyringTokenRead (>= 2.31) from keyringAuth (>= 2.29) feature flags
- Combine duplicate resolveKeyringBinary/resolveReadTokenBinary with explicit feature param
- Extract tempFilePath() utility with crypto.randomUUID, replacing 4 inline patterns
- Add withProgress() wrapper, adopt in commands.ts and promptUtils.ts
- Type-safe circular dependency guard in ServiceContainer via ref object
- Fix stubExecFileAbortable to handle non-pre-aborted signals
- Replace regex test matchers with structural assertions
- Separate keyringTokenRead (>= 2.31) from keyringAuth (>= 2.29) feature flags - Combine duplicate resolveKeyringBinary/resolveReadTokenBinary with explicit feature param - Extract tempFilePath() utility with crypto.randomUUID, replacing 4 inline patterns - Add withProgress() wrapper, adopt in commands.ts and promptUtils.ts - Type-safe circular dependency guard in ServiceContainer via ref object - Fix stubExecFileAbortable to handle non-pre-aborted signals - Replace regex test matchers with structural assertions
mtojek
approved these changes
Mar 11, 2026
mtojek
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.