Issue 71: Add default column width for slimmer viewport widths#74
Merged
Merged
Conversation
✅ Deploy Preview for codetv ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👷 Deploy request for codetv-automations pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for codetv-links ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected Result
When I load the hackathon pages into viewports slimmer than 1024px, I expect to see the hackathon cards load and their contents be clearly legible.
Current Result
When I load the hackathon pages, any Cards rendered in a Grid component are rendered in 1px columns with text overflowing. This occurs despite template column definitions at a minimum viewport width of 600px and 1024px. This is due to a lack of enforced grid column width by default. This, in combination with the flex styling and other grid definitions, caused the thin render width.
Changes
This PR simply adds a default template column width and a width of 100% to ensure content fills the space. This fixes the grid matrixes for both the hackathons main page and submission page.
Hackathon main page (before/after) -
Hackathon submission page (before/after) -