Skip to content

Update tab switch event handling in Tabs component#1035

Merged
gciotola merged 2 commits intomainfrom
tabs
Feb 11, 2026
Merged

Update tab switch event handling in Tabs component#1035
gciotola merged 2 commits intomainfrom
tabs

Conversation

@gciotola
Copy link
Contributor

@gciotola gciotola commented Feb 11, 2026

What I did

This PR solves a bug with the onTabSwitch callback that is fired too many times.
Instead of relying on useEffect the callback is now called directly on the tab click action.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@netlify
Copy link

netlify bot commented Feb 11, 2026

Deploy Preview for commercelayer-app-elements ready!

Name Link
🔨 Latest commit b7c259c
🔍 Latest deploy log https://app.netlify.com/projects/commercelayer-app-elements/deploys/698c58247a999000080a13dc
😎 Deploy Preview https://deploy-preview-1035--commercelayer-app-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 11, 2026

npm i https://pkg.pr.new/commercelayer/app-elements/@commercelayer/app-elements@1035

commit: b7c259c

@gciotola gciotola self-assigned this Feb 11, 2026
@gciotola gciotola added the bug Something isn't working label Feb 11, 2026
@gciotola gciotola merged commit ea009d0 into main Feb 11, 2026
7 checks passed
@gciotola gciotola deleted the tabs branch February 11, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants