Fix tox testing#1740
Merged
noirbizarre merged 2 commits intocommitizen-tools:v4-11-0from Dec 28, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-11-0 #1740 +/- ##
========================================
Coverage 97.84% 97.84%
========================================
Files 60 60
Lines 2604 2604
========================================
Hits 2548 2548
Misses 56 56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
woile
approved these changes
Dec 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tox test suite (
poetry test:all) is currently failing:This PR fixes the tox test suite with the current stack.
The only remaining failures are those fixed in #1726 (@bearomorphism this might interest and help you testing against all versions)
Checklist
Code Changes
testdependency-groupsintoxpytest-gitconfiginstead of thegit_sandboxfixture (allows safe and easy changes on gitconfig, (cf.test_gitwhich was setting some local git config during the test)toxcwdis not the repository root):repo_root: path to the current repository rootin_repo_root: change the currentcwdto the repository rootdata_dir: path to the test dataDocumentation Changes
No documentation change
Expected Behavior
poetry test:allworks and failure are legit broken cases.Steps to Test This Pull Request
masterorv4-11-0poetry install --all-groupspoetry test:all: it fails to runpoetry install --all-groupspoetry test:all: it runs. Only failure are for 3.13 and 3.14, the cases being fixed by test(commands): centralize all --help tests in a file to dedup code #1726Additional Context
I think this is the first PR of a "cleaning the tests" serie.
Might come after in other PRs:
*_pathfixtures everywhere,Pathlib-based everywhere, dedup some inner conftest fixtures