-
Notifications
You must be signed in to change notification settings - Fork 26
Add Azure and GCP ingress access point and gateway support #3283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Elango Jagadeesan (ejagade)
wants to merge
9
commits into
main
Choose a base branch
from
ipl-support-azure-gcp-accesspoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bbc56ce
Add GCP Ingress Private Service Connect gateway support
ejagade 3472dad
Add mock-test/ to .gitignore
ejagade 77786cd
Add Azure and GCP ingress access point and gateway support
ejagade 948299b
Upgrade networking-gateway and networking-access-point to v0.13.0
andrewveenstra d0b9ab4
Fix GCP gateway type naming to match networking API
andrewveenstra f37e883
Accept gcp-*-privatelink as gateway type filter while keeping display…
andrewveenstra ddd2d41
Address PR review feedback from Steven Gagniere
andrewveenstra 23cd708
Fix gci struct alignment formatting
andrewveenstra fb055ef
Address PR review feedback from cqin-confluent
richardyangms3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| /dist/ | ||
| /docs/ | ||
| /legal/ | ||
| /mock-test/ | ||
| /prebuilt/ | ||
| /test/bin/ | ||
| /test/coverage/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After we add GCP and Azure to the existing AWS support, each cloud's required-flag check would silently accepts wrong-cloud flags (e.g. --private-endpoint-resource-id with --cloud gcp).
Could we:
Add
cmd.MarkFlagsMutuallyExclusive("vpc-endpoint-id", "private-endpoint-resource-id", "private-service-connect-connection-id")to catches scenario of two flags set together.In each cloud's branch, reject flags that belong to the other clouds. For example, in AWS branch:
That would give users a precise error message at parse time instead passing downstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed — added
MarkFlagsMutuallyExclusivefor the three cloud-specific flags, and each cloud branch now explicitly rejects flags belonging to the other clouds with a clear error message.