Add deletion_protection support for kafka cluster #3318
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| package kafka | ||
|
|
||
| import ( | ||
| "io" | ||
| "net/http" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestParseDeletionProtectionErrDetail(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| response *http.Response | ||
| expectedDetail string | ||
| expectedOk bool | ||
| }{ | ||
| { | ||
| name: "nil response", | ||
| response: nil, | ||
| expectedOk: false, | ||
| }, | ||
| { | ||
| name: "non-conflict status code", | ||
| response: &http.Response{ | ||
| StatusCode: http.StatusBadRequest, | ||
| Body: io.NopCloser(strings.NewReader(`{"errors": [{"code": "deletion_protection_enabled", "detail": "test"}]}`)), | ||
| }, | ||
| expectedOk: false, | ||
| }, | ||
| { | ||
| name: "conflict with deletion protection error code", | ||
| response: &http.Response{ | ||
| StatusCode: http.StatusConflict, | ||
| Body: io.NopCloser(strings.NewReader(`{"errors": [{"code": "deletion_protection_enabled", "detail": "Cluster deletion is blocked by deletion protection."}]}`)), | ||
| }, | ||
| expectedDetail: "Cluster deletion is blocked by deletion protection.", | ||
|
Check failure on line 38 in internal/kafka/command_cluster_delete_test.go
|
||
| expectedOk: true, | ||
| }, | ||
| { | ||
| name: "conflict with different error code", | ||
| response: &http.Response{ | ||
| StatusCode: http.StatusConflict, | ||
| Body: io.NopCloser(strings.NewReader(`{"errors": [{"code": "some_other_error", "detail": "some detail"}]}`)), | ||
| }, | ||
| expectedOk: false, | ||
| }, | ||
| { | ||
| name: "conflict with empty errors array", | ||
| response: &http.Response{ | ||
| StatusCode: http.StatusConflict, | ||
| Body: io.NopCloser(strings.NewReader(`{"errors": []}`)), | ||
| }, | ||
| expectedOk: false, | ||
| }, | ||
| { | ||
| name: "conflict with invalid JSON body", | ||
| response: &http.Response{ | ||
| StatusCode: http.StatusConflict, | ||
| Body: io.NopCloser(strings.NewReader(`not json`)), | ||
| }, | ||
| expectedOk: false, | ||
| }, | ||
| { | ||
| name: "conflict with nil body", | ||
| response: &http.Response{ | ||
| StatusCode: http.StatusConflict, | ||
| Body: nil, | ||
| }, | ||
| expectedOk: false, | ||
| }, | ||
| { | ||
| name: "deletion protection error is not first in errors array", | ||
| response: &http.Response{ | ||
| StatusCode: http.StatusConflict, | ||
| Body: io.NopCloser(strings.NewReader(`{"errors": [` + | ||
| `{"code": "some_other_error", "detail": "other error"},` + | ||
| `{"code": "deletion_protection_enabled", "detail": "Cluster deletion is blocked by deletion protection."}` + | ||
| `]}`)), | ||
| }, | ||
| expectedDetail: "Cluster deletion is blocked by deletion protection.", | ||
| expectedOk: true, | ||
| }, | ||
| { | ||
| name: "body is restored after reading", | ||
| response: &http.Response{ | ||
| StatusCode: http.StatusConflict, | ||
| Body: io.NopCloser(strings.NewReader(`{"errors": [{"code": "deletion_protection_enabled", "detail": "Cluster deletion is blocked by deletion protection."}]}`)), | ||
| }, | ||
| expectedDetail: "Cluster deletion is blocked by deletion protection.", | ||
| expectedOk: true, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| detail, ok := parseDeletionProtectionErrDetail(tt.response) | ||
| require.Equal(t, tt.expectedOk, ok) | ||
| require.Equal(t, tt.expectedDetail, detail) | ||
|
|
||
| // Verify body is restored for downstream handlers | ||
| if tt.response != nil && tt.response.Body != nil && ok { | ||
| body, err := io.ReadAll(tt.response.Body) | ||
| require.NoError(t, err) | ||
| require.NotEmpty(t, body) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestDeletionProtectionErrorToSuggestion(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| errorMsg string | ||
| expectedSuggestion string | ||
| }{ | ||
| { | ||
| name: "cluster deletion protection", | ||
| errorMsg: "Cluster deletion is blocked by deletion protection.", | ||
| expectedSuggestion: `Disable deletion_protection before deleting the cluster.`, | ||
| }, | ||
| { | ||
| name: "cluster deletion protection case insensitive", | ||
| errorMsg: "cluster deletion is blocked by deletion protection.", | ||
| expectedSuggestion: `Disable deletion_protection before deleting the cluster.`, | ||
| }, | ||
| { | ||
| name: "unknown deletion protection error", | ||
| errorMsg: "Some other deletion protection error.", | ||
| expectedSuggestion: "", | ||
| }, | ||
| { | ||
| name: "empty string", | ||
| errorMsg: "", | ||
| expectedSuggestion: "", | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| suggestion := deletionProtectionErrorToSuggestion(tt.errorMsg) | ||
| require.Equal(t, tt.expectedSuggestion, suggestion) | ||
| }) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.